Clear CommandCursorResult.results after next()/tryNext(). #1780
+30
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…aining consumed batches while cursor stays open. JAVA-5940
vbabanin
changed the title
There was a problem hiding this comment.
Pull Request Overview
This PR addresses memory usage optimization by clearing the results list in CommandCursorResult after cursor operations. The change ensures that once results are consumed via next() or tryNext(), the internal results collection is emptied to prevent memory retention.
- Adds a factory method to create CommandCursorResult instances with empty results
- Modifies CommandBatchCursor to clear results after consumption
- Introduces a private constructor for internal use in the factory method
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| CommandCursorResult.java | Adds factory method and private constructor to support creating instances with empty results |
| CommandBatchCursor.java | Clears commandCursorResult.results after consuming batch data in doNext() |
driver-core/src/main/com/mongodb/internal/operation/CommandCursorResult.java
Show resolved
Hide resolved
rozza
reviewed
Aug 11, 2025
Good point, I’ve added the change for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JAVA-5940